UserStorage: allow sessionSection to be null#243
Open
kostirez1 wants to merge 4 commits into
Open
Conversation
dg
force-pushed
the
v3.3
branch
5 times, most recently
from
December 30, 2025 00:43
8ca4248 to
3aa0b3b
Compare
dg
force-pushed
the
v3.3
branch
6 times, most recently
from
February 10, 2026 02:52
a35df87 to
c0033dc
Compare
dg
force-pushed
the
v3.3
branch
2 times, most recently
from
February 26, 2026 05:53
c6b5a15 to
9efaa14
Compare
dg
force-pushed
the
v3.3
branch
4 times, most recently
from
May 26, 2026 16:58
264bb23 to
d92cb97
Compare
dg
force-pushed
the
v3.3
branch
2 times, most recently
from
July 13, 2026 21:22
8755cb0 to
159dbcd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Broken since 3.3.0 (added property typehints) due to the code relying on
$sessionSectionproperty being nullable and preinitialized to null during creation. Currently failing onError: Typed property Nette\Http\UserStorage::$sessionSection must not be accessed before initializationwhen callinggetSessionSection()This commit reverts
$sessionSectionto the same behavior it had before adding the native typehint.Branch v3.3 is the only affected one,
masterandv4.0no longer contain this deprecated class (removed deprecated stuff).